-
-
Notifications
You must be signed in to change notification settings - Fork 888
Add new Color parsing methods. #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
+ Coverage 81.53% 82.22% +0.69%
==========================================
Files 704 702 -2
Lines 29384 29159 -225
Branches 3290 3296 +6
==========================================
+ Hits 23957 23977 +20
+ Misses 4734 4491 -243
+ Partials 693 691 -2
Continue to review full report at Codecov.
|
|
@SixLabors/core Any objections to this. I'll add it tonight otherwise. |
i have looked trough the changes. Looks good to me, i think it can be merged. |
|
Is this the commit that broke examples that use like?: image.Mutate(x => x.BackgroundColor(Rgba32.White));I suppose the replacement is just using |
|
There’s nothing broken, this is by design. |
|
I didn't say it was broken, I said it broke the examples 😄 |
|
Which examples are broken? I’ll update if we own them. |
|
I followed this path to here: Thanks for this library. |
|
@jespersh no worries! yeah, that's all out of date. We've got API docs https://docs.sixlabors.com/ that will be much more useful. |
Prerequisites
Description
Color.TryParseColor.ParseColor.TryParseHexColor.FromHextoColor.ParseHexRgba32.TryParseHexRgba32.FromHextoRgba32.ParseHexColor.TryParseandColor.Parserecognize both color names and hexadecimal representation as per CSS4 specification in ordinal casing. Fix #1103I haven't addedRgba32.TryParseandRgba32.Parseas I'm very tempted to drop theRgba32named colors. I'd much rather channel color creation through theColorstruct only.Please let me know if you agree that this is the best course of action.EDIT. I went ahead and deleted them. Much happier now.