Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #1004 Changes the behavior of the ZlibInflateStream to throw only when operating on a critical chunk.

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #1005 into master will decrease coverage by 0.11%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   89.77%   89.66%   -0.12%     
==========================================
  Files        1098     1098              
  Lines       48810    48819       +9     
  Branches     3433     3438       +5     
==========================================
- Hits        43821    43772      -49     
- Misses       4284     4292       +8     
- Partials      705      755      +50
Impacted Files Coverage Δ
...ts/ImageSharp.Tests/Formats/Png/PngDecoderTests.cs 100% <ø> (ø) ⬆️
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...c/ImageSharp/Formats/Png/Zlib/ZlibInflateStream.cs 57.97% <30%> (-0.5%) ⬇️
src/ImageSharp/Formats/Png/PngDecoderCore.cs 85.44% <92.3%> (-0.22%) ⬇️
...xelFormats/PixelOperations{TPixel}.PixelBenders.cs 89.9% <0%> (-10.1%) ⬇️
...olorSpaces/Conversion/ColorSpaceConverter.Adapt.cs 60% <0%> (-8.58%) ⬇️
...Processing/Processors/Transforms/TransformUtils.cs 87.64% <0%> (-6.75%) ⬇️
src/ImageSharp/Primitives/ValueSize.cs 78.94% <0%> (-5.27%) ⬇️
src/ImageSharp/Common/Helpers/ImageMaths.cs 82.05% <0%> (-5.13%) ⬇️
....Tests/TestUtilities/Tests/TestEnvironmentTests.cs 63.63% <0%> (-4.55%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceff1cc...dbc5c76. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 8, 2019

Codecov Report

Merging #1005 into master will decrease coverage by <.01%.
The diff coverage is 71.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.01%     
==========================================
  Files        1098     1098              
  Lines       48851    48863      +12     
  Branches     3428     3433       +5     
==========================================
+ Hits        43898    43908      +10     
- Misses       4252     4254       +2     
  Partials      701      701
Impacted Files Coverage Δ
...ts/ImageSharp.Tests/Formats/Png/PngDecoderTests.cs 100% <ø> (ø) ⬆️
tests/ImageSharp.Tests/TestImages.cs 100% <ø> (ø) ⬆️
...c/ImageSharp/Formats/Png/Zlib/ZlibInflateStream.cs 61.11% <52.38%> (+2.64%) ⬆️
src/ImageSharp/Formats/Png/PngDecoderCore.cs 85.65% <94.44%> (ø) ⬆️
...eSharp.Tests/Formats/Png/PngDecoderTests.Chunks.cs 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e0508...221000e. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor CQ related comment, but otherwise looks good. (My knowledge of PNG is limited though.)

@JimBobSquarePants JimBobSquarePants merged commit 5b73284 into master Sep 11, 2019
@JimBobSquarePants JimBobSquarePants deleted the issue/1004 branch September 11, 2019 03:33
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PngDecoder should not throw when encountering invalid Zlib data for non critical chunks.

3 participants