Image processing exception: out of memory

[Bazeloth]

Prerequisites

• I have written a descriptive issue title
• I have verified that I am running the latest version of ImageSharp
• I have verified if the problem exist in both DEBUG and RELEASE mode
• I have searched open and closed issues to ensure it has not already been reported

Description

We deployed ImageSharp to an Azure App Service running in 64 bit mode. We've included the following runtime configuration, which let's it run in 64 bit mode:
<RuntimeIdentifiers>win-x64</RuntimeIdentifiers>

I can expect this Exception to occur in 32-bit mode, but not in 64-bit mode:

SixLabors.ImageSharp.ImageProcessingException: An error occurred when processing the image using ResizeProcessor1. See the inner exception for more detail. ---> System.OutOfMemoryException: Exception of type 'System.OutOfMemoryException' was thrown.
at System.Buffers.ConfigurableArrayPool1.Rent(Int32 minimumLength) at SixLabors.ImageSharp.Memory.ArrayPoolMemoryManager.Allocate[T](Int32 length, Boolean clear) at SixLabors.ImageSharp.Memory.MemoryManagerExtensions.Allocate2D[T](MemoryManager memoryManager, Int32 width, Int32 height, Boolean clear) at SixLabors.ImageSharp.Processing.Transforms.Processors.ResizeProcessor1.OnFrameApply(ImageFrame1 source, ImageFrame1 destination, Rectangle sourceRectangle, Configuration configuration)
at SixLabors.ImageSharp.Processing.Processors.CloningImageProcessor1.CloneAndApply(Image1 source, Rectangle sourceRectangle)
--- End of inner exception stack trace ---
at SixLabors.ImageSharp.Processing.Processors.CloningImageProcessor1.CloneAndApply(Image1 source, Rectangle sourceRectangle)
at SixLabors.ImageSharp.Processing.Processors.CloningImageProcessor1.Apply(Image1 source, Rectangle sourceRectangle)
at SixLabors.ImageSharp.Processing.DefaultInternalImageProcessorContext1.ApplyProcessor(IImageProcessor1 processor, Rectangle rectangle)
at SixLabors.ImageSharp.Processing.DefaultInternalImageProcessorContext1.ApplyProcessor(IImageProcessor1 processor)
at Editor.Libraries.Images.ImageExtensions.<>c__DisplayClass0_0.b__0(IImageProcessingContext1 operation)

Steps to Reproduce

To be honest, i can't reproduce it yet. Probably a customer has generated this Exception.

System Configuration

We're running this in an Azure App service running on 64-bit.

• ImageSharp version:
  1.0.0-beta0003

• Environment (Operating system, version and so on):
  Azure App Service (64 bit)

• .NET Framework version:
  asp.net core 2.0

[jongleur1983]

How much memory is available in your azure instance? What's the code that fails here, what's the input image (size and format)?

[JimBobSquarePants]

Can you update to beta 4 and see how you get on please?

[Spawnkid]

same error as mine, I updated my nuget to beta 4 last night and when I tried to run in VS2017 I got this:

Exception happens here:
using (Image image = Image.Load(filename))

Exception Message:
Method not found: 'System.Span1<!!1> System.Runtime.InteropServices.MemoryMarshal.Cast(System.Span1<!!0>)'.

Stack Trace:
at SixLabors.ImageSharp.Memory.ArrayPoolMemoryManager.Buffer1.get_Span() at SixLabors.ImageSharp.Image.<>c__DisplayClass0_0.<InternalDetectFormat>b__0(IImageFormatDetector x) at System.Linq.Enumerable.WhereSelectEnumerableIterator2.MoveNext()
at System.Linq.Enumerable.LastOrDefault[TSource](IEnumerable1 source, Func2 predicate)
at SixLabors.ImageSharp.Image.InternalDetectFormat(Stream stream, Configuration config)
at SixLabors.ImageSharp.Image.DiscoverDecoder(Stream stream, Configuration config, IImageFormat& format)
at SixLabors.ImageSharp.Image.Decode[TPixel](Stream stream, Configuration config)
at SixLabors.ImageSharp.Image.<>c__DisplayClass46_01.<Load>b__0(Stream s) at SixLabors.ImageSharp.Image.WithSeekableStream[T](Configuration config, Stream stream, Func2 action)
at SixLabors.ImageSharp.Image.Load[TPixel](Configuration config, Stream stream, IImageFormat& format)
at SixLabors.ImageSharp.Image.Load[TPixel](Configuration config, String path)
at SixLabors.ImageSharp.Image.Load(String path)
at Test.Controls.ImageHelper.LoadImage(String filename, Int32 size) in C:\Source\Test\Test\Controls\ImageHelper.cs:line 19
at Test.ViewModel.MainViewModel.<>c__DisplayClass140_0.b__0() in C:\Source\Test\Test\ViewModel\MainViewModel.cs:line 325
at System.Threading.Tasks.Task.InnerInvoke()
at System.Threading.Tasks.Task.Execute()

[Spawnkid]

Update: It seems that only the beta4 of ,NET framework (mine is 4.7.1) has the problem. My base class library also uses beta 4 (Net Standard 2.0) and did not shown any issues at all.

[JimBobSquarePants]

@Spawnkid That’s not the same exception. You’ve got reference issues.

[Spawnkid]

Hi Jim, thanks for the response. I don't exactly understand why I got reference issues only when using beta 4 (in the .net 4.7 wpf). But just reverting back to beta 3 everything worked. Odd is, all the 3 netstandard classes that used by the .net 4.7 project uses beta 4 of imagesharp and imagesharp.drawing and no error was thrown out when I'm calling them. Do I need to add new reference dll when I use the beta 4 of .net 4.7 imagesharp/drawing?

[Bazeloth]

@JimBobSquarePants and @jongleur1983 , i do not have an example. A customer uploaded it and i do not have the image as it didnt get saved. All i know it's a jpeg and and unknow size. We allow images to be uploaded up to 30 MB and we've configured ImageSharp to do the following:

Configuration.Default.MemoryManager = ArrayPoolMemoryManager.CreateWithMinimalPooling();

I do not know how to reproduce it, nor will i be able to confirm if it's absent in V4 if i do upgrade.

[antonfirsov]

@isualize do you know the memory limit of your container? If it's too low is it possible to scale it up? Any info/estimation regarding your load? (no of requests/minute)

Not my favorite advice but also try out SimpleGcMemoryManager.

[Bazeloth]

@antonfirsov it's running on it's own app service plan with 3.5 GB's of RAM available. We've got autoscaling setup with the following rules:

average cpu percentage >= 70 -> increase instance count by 1
average memory percentage >= 70 -> increase instance count by 1

average cpu percentage <= 50 -> decrease instance count by 1
average memory percentage <= 55 -> decrease instance count by 1

The minimum number of instances is 1, the max is 6. These are the charts with running at 3 instances:

Any idea's what's wrong? It's not going above 60% memory usage according to the charts. Im not sure about using a different memory manager.. I've removed the following line and let it run a day:

Configuration.Default.MemoryManager = ArrayPoolMemoryManager.CreateWithMinimalPooling();

However with the default memory manager assigned to imagesharp i'm still getting the same out of memory exceptions in the logs. :(

[antonfirsov]

@isualize your usage data might be super-valuable for us!
If we add allocation tracing to beta5, are you interested sharing future ImageSharp logs with us?

This would help us solving memory issues.

[Bazeloth]

@antonfirsov i'd have to ask work sine it's their code, but that's definately a yes from me :)

Is there anything else i can do to help you track down the issue at the moment?

[andymac4182]

@antonfirsov We have ImageSharp.Web running in production resizing a few hundred images a day. Happy to get the logs from beta5 / nightly if that can help.

[antonfirsov]

@isualize @andymac4182 thanks! 👍 @tocsoft is working on a Telemetry solution that will minimize the efforts on your side, hope we can make it into beta5.

I also hope that with #642 I can significantly reduce the memory consumption for resizing use-cases. It is planned for RC1.

[andymac4182]

Looking forward to it @antonfirsov. Once I see #642 merged I will look at trialling in in our dev environment. We are running from the myget feed currently so should be a fairly small change.