Skip to content

Implicit Global Usings #389

@antonysmith-mandogroup

Description

@antonysmith-mandogroup

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of ImageSharp.Web
  • I have verified if the problem exist in both DEBUG and RELEASE mode
  • I have searched open and closed issues to ensure it has not already been reported

ImageSharp.Web version

3.1.5

Other Six Labors packages and versions

SixLabors.ImageSharp 3.1.10

Environment (Operating system, version and so on)

Windows

.NET version

8.0

Description

In SixLabors.ImageSharp, there was a discussion re: the addition of global usings by default where projects had enabled implicit usings: SixLabors/ImageSharp#2381

The result of this was that the functionality was updated to include the usings via opt-in, rather than automatically: SixLabors/ImageSharp#2515

Would it be possible to have the change reflected in SixLabors.ImageSharp.Web too, please?

We have a dependency on a package which depends on both SixLabors.ImageSharp and SixLabors.ImageSharp.Web and we are therefore experiencing the issue with global usings being added as a result of the previous behaviour still existing in Web:

<ItemGroup Condition="'$(ImplicitUsings)'=='enable' OR '$(ImplicitUsings)'=='true'">

I appreciate that the original discussion indicates there was some friction in making this change, and certainly do not want to antagonise. However, given it was made in SixLabors.ImageSharp, apart from anything else it feels like it may make sense to also change it in SixLabors.ImageSharp.Web from a consistency POV.

Thanks in advance.

Steps to Reproduce

  1. Install SixLabors.ImageSharp, build and notice that global usings do not contain SixLabors namespaces
  2. Install SixLabors.ImageSharp.Web, build and notice that global usings now contain SixLabors namespaces

Images

Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions