Fix SkipEdgesBeforeMinY algorithm #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 69.98% 69.98% -0.01%
==========================================
Files 89 89
Lines 5201 5204 +3
Branches 1062 1065 +3
==========================================
+ Hits 3640 3642 +2
Misses 1347 1347
- Partials 214 215 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
Author
|
I'm still not big friend of codecov.
|
JimBobSquarePants
approved these changes
Oct 23, 2021
| // Do fake scans of the lines that start before minY. | ||
| // Instead of fake scanning at every possible subpixel Y location, | ||
| // only "scan" at start edge Y positions (defined by values in sorted0) and end Y positions (defined by values in sorted1). | ||
| // Walk the two lists simultaneously following mergesort logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The original
SkipEdgesBeforeMinY()implementation in #96 forgot to watch cases when all edges of the rendered polygon crossed the top boundary, meaning that allScanEdgeY0are< minY, leading toi0overflowthis.sorted0. #119 added a workaround for some cases but broke the merge sort -style coordinate walking algorithm which should always pick the next smaller coordinate to traverse the elements of two sorted lists in ascending order.The PR adds bounds checks to the original algorithm. Fixes #170, fixes #108.