This repository was archived by the owner on Oct 20, 2023. It is now read-only.
This repository was archived by the owner on Oct 20, 2023. It is now read-only.
theme-product-form onSubmit option ID setting conflicts with buy now button #146
Description
The way the product form handles changing options doesn't work with the "Buy It Now" button on product pages.
When you have a set of options, ProductForm will update the value of the "id" field to use the chosen variant. This happens through a submit listener on the product form.
ProductForm.prototype._onSubmit = function(options, event) {
event.dataset = this._getProductFormEventData();
this._setIdInputValue(event.dataset.variant.id);
if (options.onFormSubmit) {
options.onFormSubmit(event);
}
};
When you press add to cart, the ID gets updated, and the correct variant is added to the user's cart. When you click the Buy It Now button however, that submit handler doesn't fire and the default variant shows in the checkout instead.
The simplest solution would likely be to move the point at which the id value is updated from submit to an option being changed.