clarify instructions in readme.md

[M00NSH0T]

Overview/summary

Step 4 in the instructions include a line:

access_token = session.request_token(request_params)

But it's unclear from a lamen's perspective what request_params should be. Please add some clarification around how to define request_params.

Motivation

What inspired this enhancement?

Tring to get up and running quickly with the API...

Area

• Add any relevant Area: <area> labels to this issue

---

Checklist

• I have described this enhancement in a way that is actionable (if possible)

[mllemango]

Hey @M00NSH0T, you raise a really good point. The team will add it to the backlog, in the meantime we always welcome PRs!

[eporto2021]

Can someone help a lamen out and clarify exactly what needs to be passed to the request_token() function, say with an example of 'request_params' ?

[tamirble]

I was stuck here too. This is how I solved it.

code_you_got_from_redirection = "********"

session = shopify.Session(shop_url, api_version)

timestamp = time()
request_params = {
    'timestamp': timestamp,
    'code': code_you_got_from_redirection
}

hmac_ = session.calculate_hmac(request_params)
request_params['hmac'] = hmac_
access_token = session.request_token(request_params)

[ianjosephwilson]

@tamirble The code is hard to follow but I think the timestamp and hmac should be provided by shopify via a GET argument. The library checks the hmac is correct to verify the request was sent by shopify. There is also a check against the timestamp.

[github-actions]

This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days.

[github-actions]

We are closing this issue because it has been inactive for a few months.
This probably means that it is not reproducible or it has been fixed in a newer version.
If it’s an enhancement and hasn’t been taken on since it was submitted, then it seems other issues have taken priority.

If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines

Thank you!

[li5tun]

the parameters from step 3 must be like this: code=abcd1234&hmac=aaaaaaaa&host=asdfasdf&shop=abc.myshopify.com&state=aaaaaaa&timestamp=12345, convert it to a dict:

request_params = { 'code': 'abcd1234', 'hmac': 'aaaaaaaa', 'host': 'asdfasdf', 'shop': 'abc.myshopify.com', 'state': 'aaaaaaa', 'timestamp': 12345, }

timestamp is a # INTEGER