Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem summary:
Currently shopify_python requires pylint ~= 2.1.1. But,
pylint
v2.1.* has this dependency issue on'isort >= 4.2.5
. There's no dependency constraint there, so eventuallyisort
releasedv5
. pylint 2.1.1 picks up the new version and breaks.More recently,
pylint 2.6.0
supportsisort v5
pylint-dev/pylint#3725This PR relaxes the dependency constraint so
shopify_python
will pick up the newerpylint
version.This PR fixes #114
I tested this by:
[ ] pytest locally
[ ] push to PyPi test and test fix downstream in Panama CI