Add Ruby 3.2 & 3.3 to CI matrix #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an indirect dependency on `base64` which causes the following
warning on Ruby 3.3:
warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0.
Add base64 to your Gemfile or gemspec. Also contact author of rubocop-1.53.0 to add base64 into its gemspec.
This has been fixed upstream, however we still run into it when testing
against the minimum compatible RuboCop version, hence adding the
dependency.
This was referenced Feb 12, 2024
Merged
rafaelfranca
approved these changes
Feb 14, 2024
sambostock
added a commit
that referenced
this pull request
Mar 28, 2025
This was added in #613 to address a warning when running with old RuboCop versions against new (at the time) Ruby versions. This warning was addressed in rubocop/rubocop#12313 (released in RuboCop version 1.57.2), and as out minimum RuboCop version has surpassed that, we can remove the dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Ruby 3.2 & 3.3 to the CI matrix.
To get around a warning emitted when testing old RuboCop versions against Ruby 3.3,
base64is added to theGemfileas a development dependency. This is fixed upstream, but we can't benefit from that fix until we drop support for the RuboCop versions without the fix, so simply following the warning message and adding it to ourGemfileis the simplest thing.Finally, the development Ruby version is bumped to 3.3.0.