WIP: Update React Experimental to support server context #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
changed the base branch from
fd-update-react-experimental
to
v1.x-2022-07
jplhomer
commented
Mar 9, 2022
Comment on lines
+42
to
+43
| "react": "^0.0.0-experimental-a59f53a60-20220308", | ||
| "react-dom": "^0.0.0-experimental-a59f53a60-20220308", |
Contributor
Author
There was a problem hiding this comment.
Whoops these should be pinned without carrots
jplhomer
commented
Mar 9, 2022
| nonce, | ||
| }); | ||
|
|
||
| await ssrReadable.allReady.then(() => onCompleteAll.resolve(null)); |
Contributor
Author
There was a problem hiding this comment.
Should remove the await here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, based off the original in #758
Required a couple modifications to our (unmerged) Vite RSC plugin: https://github.com/jplhomer/react/tree/rsc-vite to support server context.
A few issues we're already seeing here:
useContextdoesn't throw anymore, so we can't rely on that as a mechanism for isomorphic server-only context. Need to find some other way to determine when we're in a RSC runtime - maybe flip the order so we try to read from cache (which fails) first?