Upgrade recyclerlistview to v4.2.1 #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvarandas
reviewed
Jun 18, 2024
Contributor
gvarandas
left a comment
gvarandas
left a comment
There was a problem hiding this comment.
Changes LGTM (thanks for fixing the e2e path)!
It looks like the tests failed on CI, though, so we might need to address those.
Collaborator
Author
|
@gvarandas Working on it. They pass locally but fail on CI for some reason. Trying to fix artifact upload job to see what's happening. |
tmgsca
approved these changes
Jun 18, 2024
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #784 and potential issue where a blank space can be visible below the first row when list only has one item. This PR also adds functionality to allow access to scroll view's native ref.
Both issues were in recyclerlistview which is being update. RLV release can be found here.
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist