This repository was archived by the owner on Sep 5, 2024. It is now read-only.
update from master #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked through the files and tried to replace what propType dependencies I could find with string literals. I also tried out the Example app with babel-plugin-transform-react-remove-prop-types and it seemed to me like it was working (also verified that the propTypes actually was removed by printing them to the console and making sure they were undefined). However, if someone with more experience with the code base could take a gander at the changes and verify that it is working that would be great, I'd if I missed anything and it accidentally got merged. Since I have limited experience with all the components I might have missed some regressions but I hope not. Thanks in advance 🙂 This should fix #548. Co-Authored-By: Michał Osadnik <[email protected]>
FlatList: Adds argument ItemT, as on react-native original definition
This PR changes the way we export gesture-handler-wrapped components. Instead of importing them from RN we rely on lazy-load mechanism (that is also utilize in RN core) to only pull in core components that we need. On top of that I added memoization mechanism such that for each component only one wrapper component is created. This change makes GH more future proof as some core components (e.g. AndroidToolbar) are being removed from react-native. This will allow consumers to keep using these so long they rely on RN version that have them included (full backward compatibility). And also allow for consumers relying on new RN versions to wrap components from react-native-community github in case they want to continue using these.
# Why Default import was removed from react-native-web. necolas/react-native-web#1277 The use of module.exports and import/export breaks tree-shaking in with babel-preset-expo. Related: #617 Fixes: expo/expo#4339 # How * Moved the shims to `Gestures(.web).js` * Moved all modules out of main re-export file. (optional)
The buttons don't style or function as expected in the browser. This fixes the bugs related to them (only tested on web so far).
Same as software-mansion/react-native-reanimated#298 Although we have kept them up to date pretty well, a `>=` matcher isn't exactly the most useful as a future version of either lib could easily break support. These sorts of warnings aren't the most useful in the ecosystem right now, perhaps when it stabilizes more.
RN only supports iOS 9+ now so we can remove this according to the comment.
To silence the react warning, ideally we'd migrate to new React apis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.