Skip to content

Add DelegatedManagerSystem API #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 31, 2022
Merged

Add DelegatedManagerSystem API #107

merged 19 commits into from
Mar 31, 2022

Conversation

@cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Mar 10, 2022 •
edited
Loading

Adds:

  • DelegatedManagerFactoryAPI
  • IssuanceExtensionAPI
  • TradeExtensionAPI
  • StreamingFeeExtensionAPI

Extensions are available on an extensions object exposed by the SetJS instance

setJS.extensions.tradeExtension.tradeForOperator(....)

TODO

  • Update set-v2-strategies packages to 0.0.7
  • Check that imported ABIs DO NOT have hardcoded gas values
    • is it possible to make set-protocol-v2 a dev-dependency at set-v2-strategies?
  • Un-ts-ignore missing imports
  • Complete tests

cgewecke
cgewecke commented Mar 14, 2022
View reviewed changes
cgewecke
cgewecke commented Mar 14, 2022
View reviewed changes
@cgewecke cgewecke force-pushed the chris/delegatedFactoryManagerAPI branch from 0299d41 to 2bda623 Compare March 25, 2022 00:35
controtie
controtie approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@controtie controtie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgewecke cgewecke merged commit 8e9aee6 into master Mar 31, 2022
@cgewecke cgewecke deleted the chris/delegatedFactoryManagerAPI branch March 31, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@controtie controtie controtie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cgewecke @controtie