API bug #809
Merged
API bug #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed side-runner foreach command
Fixed the for each test.
Fixed failed test for Foreach bug fix
merge last version of V3
V3 update
cdifino
added a commit
to cdifino/selenium-ide
that referenced
this pull request
Sep 12, 2019
nbansal1993
pushed a commit
to cdifino/selenium-ide
that referenced
this pull request
Oct 8, 2019
Fixed check instead of req.id req.project
corevo
pushed a commit
that referenced
this pull request
Oct 11, 2019
* Fixed side-runner foreach command * Fixed Test for foreach in Selianize Fixed the for each test. * connection mode ui changes Connected Mode Implementation Fixed check for connection ID bug Fixed prettier bug and changed description of pop up Fixed prettier bug Fixed prettier bug Plugin Manager Fix, modified dialog, window focus addition Closure Prettier Prettier Prettier Restart to welcome sccreen when entering connected mode Prettier Prettier Prettier Prettier Prettier Prettier Prettier debug travis fail restart capabiulity everytime is starting a connection prettier travis bugs travis bugs * documentation of connected mode * deleted end connection * change saving message * fix bug * prettier * deleted a unwanted file * changing errors to response with error code * Revert "Changing errors to response with error code" * Use promise to refactor the code (#12) * Use promise to refactor the code * Change the position of skipping save. * remove the restart payload from connect call. * Hide the force close endpoint. * Fix a launch problem when IDE is already in non-control mode. * convert all throw to error response. * fixing indentation issues causing build failure * adding space in comments to retrigger the build * using prettier to re-indent * Revert "using prettier to re-indent" * Revert "retrigger the build" * Revert "fixing indentation issues causing build failure" * removing unused import * indentation changes for build * bug fixes * fixing error message * reindent using eslint instead of prettier * Updated document to use goog:chromeOptions (#757) * Added first pass on command schema validation with error handling for code export and displaying the message in the GUI. * fixed typo on code-export: targret into target (#784) * Moved the isOptional declaration for arguments to the command object. * Added validation support for ignored commands, other commands with optional args (e.g., executeScript). Also added the test name to the error for easier user reference (e.g., when exporting a suite of tests that has a command error) * Added side-model package with Commands and ArgTypes * Stopped mixing ES5 & ES6 exports and added a test to verify that the index is exporting the correct thing * Updated everything to use side-model instead of direct calls to models/Command/etc * Config for stale bot, for managing issues * Remove stale bot config since it is on master now * Added linting rule for the `.only` filter applied to tests/suites * Removed .only filter from selianize index test * Added linting rules from eslint-plugin-node * Added master remnants to gitignore * Added installing the website deps to the CI config * Added userAgent checks to side-utils * Updated the beforeEach hook for each language to check the user agent to determine the browser name and default to Chrome if it's not available * Added environment checks to side-utils * Added side-utils to selenium-ide * Exposed environment from side-utils * Updated selenium-ide/common/utils to use side-utils * Added lowercasing to the JS beforeEach hook when using the browserName from the user agent * Added check for `window` before setting the userAgent in side-utils/user-agent * Catch undefined error for window in side-utils/user-agent * re: side-utils/user-agent: Forgot to call the function. Storing it in a variable and exposing it instead * Fixed erroneous reference change for Command. Fixes regression found when playing back all tests in a suite * Reset timesVisited to 0 when finished iterating through a forEach collection. Fixes #792 * Added test coverage for reseting timesVisited when completing a forEach loop. Also moved the setter into evaluateForEach * Added linting to release-prep script * Updated changelog * v3.12.2 * Fix for off-by-one error in nested forEach command blocks. Fixes #792 * Updated changelog * v3.12.3 * Added a seed test for nested forEach * Extending api to open SeleniumIDE and load projects Co-Authored-By: Tomer <[email protected]> * fixed typo * fix lint * Updated side-runner version of jest-environment-selenium * Added loopLimit param to repeatIf * Updated retryLimit to ignore forEach commands * prevent unregistered plugins from communicating with Selenium IDE * Updated changelog * lint fix * Revert error handling for unregistered commands due to a race condition which breaks plugins (and doesn't propagate the error) * Variable Property Access Co-authored-by: Tomer <[email protected]> * Added the ability to register a command in side-model * Wired up plugin command registration to side-model * Added the isOptional check to the target param too (with some cleanup) * Updated changelog * dont allow usage of npm * Fixed linting error * v3.13.0 * API bug (#809) Fixed check instead of req.id req.project * Fixed typo. Action reference should be Actions reference to avoid casting. (#743) * Fixed typo. Action should really be Actions reference to avoid casting. * Updating snapshot to ensure build succeeds * parent bb93dfe author cdifino <[email protected]> 1569005404 -0700 committer Nikhil Bansal <[email protected]> 1570570897 -0700 connection mode ui changes Connected Mode Implementation Fixed check for connection ID bug Fixed prettier bug and changed description of pop up Fixed prettier bug Fixed prettier bug Plugin Manager Fix, modified dialog, window focus addition Closure Prettier Prettier Prettier Restart to welcome sccreen when entering connected mode Prettier Prettier Prettier Prettier Prettier Prettier Prettier debug travis fail restart capabiulity everytime is starting a connection prettier travis bugs travis bugs documentation of connected mode deleted end connection change saving message fix bug prettier deleted a unwanted file changing errors to response with error code Revert "Changing errors to response with error code" Use promise to refactor the code (#12) * Use promise to refactor the code * Change the position of skipping save. * remove the restart payload from connect call. * Hide the force close endpoint. * Fix a launch problem when IDE is already in non-control mode. * convert all throw to error response. using prettier to re-indent adding space in comments to retrigger the build Revert "using prettier to re-indent" Revert "retrigger the build" Revert "fixing indentation issues causing build failure" removing unused import indentation changes for build bug fixes fixing error message reindent using eslint instead of prettier * fixing error message * reindent using eslint instead of prettier * connection mode ui changes Connected Mode Implementation Fixed check for connection ID bug Fixed prettier bug and changed description of pop up Fixed prettier bug Fixed prettier bug Plugin Manager Fix, modified dialog, window focus addition Closure Prettier Prettier Prettier Restart to welcome sccreen when entering connected mode Prettier Prettier Prettier Prettier Prettier Prettier Prettier debug travis fail restart capabiulity everytime is starting a connection prettier travis bugs travis bugs documentation of connected mode deleted end connection * fixing bugs added in squash * adding import back * adding import back * resolve review comments. * Fix some indention issue. * Fix the max-width of banner. * connected mode resolve comments. (#29) * resolve review comments. * Fix some indention issue. * Fix the max-width of banner. * updating the api documentation * indentation changes to fix build * fixing css indentation issues * Nbansal/feedbackchanges (#33) changing private apis to /private/ sending project in message on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement