Skip to content

Conversation

@ay0o
Copy link

@ay0o ay0o commented Oct 5, 2018

Issue #799 was partially caused by a missing port in the docker run
statement

Ayoze and others added 2 commits October 5, 2018 08:25
Issue #799 was partially caused by a missing port in the docker run
statement
@ay0o ay0o changed the title Missing docker port in REMOTE_HOST example. Documentation improvements and fixes Oct 5, 2018
@ay0o ay0o changed the title Documentation improvements and fixes README improvements and fixes Oct 5, 2018
@ay0o
Copy link
Author

ay0o commented Oct 5, 2018

FYI, CI is failing due to an unrelated error.

@diemol
Copy link
Member

diemol commented Oct 6, 2018

Hi @ay0o,

Thanks for the PR. Could you also please add instructions showing to to start Docker Swarm?

@ay0o
Copy link
Author

ay0o commented Oct 6, 2018

@diemol updated it, but I think that's out of the scope of docker-selenium.

@diemol
Copy link
Member

diemol commented Oct 6, 2018

Thanks for your contribution!

@diemol diemol merged commit 71657be into SeleniumHQ:master Oct 6, 2018
@ay0o ay0o deleted the fix_readme branch October 6, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants