Adding info on how to wait for the Grid to be ready #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnguyen14
reviewed
Aug 24, 2018
Base/check-grid.sh
Outdated
| do | ||
| case "$1" in | ||
| --host) | ||
| HOST="$2" |
There was a problem hiding this comment.
Could you do HOST="${2:-localhost}"?
There was a problem hiding this comment.
Good idea, I was just copying and pasting from other script. Just made the changes and I will push them now. Thanks @tnguyen14
cgoldberg
reviewed
Aug 25, 2018
README.md
Outdated
| exec $cmd | ||
| ``` | ||
| **Note:** If needed, replace `localhost` and `4444` for the correct values in your environment. Also, this script is polling indefinitely, you might want | ||
| to teak it and establish a timeout. |
|
@diemol - sorry just pulled the code and all looks good. I was going off of the dockerfile preview on https://hub.docker.com/r/selenium/base/~/dockerfile/ (this is still showing old code) |
|
No worries :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Add HEALTHCHECK entry to Dockerfiles #691 by documenting how to add a health check when starting the containers. We won't add a health check into the docker images since it is not possible to configure the intervals for it, and we don't have data to choose values that work for everyone.
Improved templates for new issues and PRs.
By placing an
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement