Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Nov 17, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Simple use of quotes to avoid values getting stripped

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol changed the title Quoting env vars in bash for sanity Adding session queuer Nov 18, 2020
@diemol diemol merged commit c7924e7 into trunk Nov 18, 2020
@diemol diemol deleted the quoting-bash-env-vars branch November 18, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants