Skip to content

Conversation

@diemol
Copy link
Member

@diemol diemol commented Sep 20, 2020

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This adds an initial set of files that will build a docker image to record the display output from other containers.
Closes #1111

Motivation and Context

Give video recording to the community.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol diemol marked this pull request as draft September 20, 2020 21:23
@diemol diemol marked this pull request as ready for review September 21, 2020 09:20
@diemol diemol merged commit 1a3b0e1 into trunk Sep 21, 2020
@diemol diemol deleted the initial-video-support branch September 22, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants