Skip to content

Improving tags for docker images #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 20, 2020
Merged

Improving tags for docker images #1086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
198cea7
Generating date automatically
diemol Jul 19, 2020
31a7077
Script to tag browser images verbosely
diemol Jul 19, 2020
49dd51e
Using script in GitHub action
diemol Jul 19, 2020
0b8ab12
Adding more tags for chrome images
diemol Jul 20, 2020
4194c64
Adding a parameter to push (or not) images
diemol Jul 20, 2020
dc4f5cc
Fixing script name
diemol Jul 20, 2020
637fa1f
Using the correct make file command [skip ci]
diemol Jul 20, 2020
77f7eb5
Debugging [skip ci]
diemol Jul 20, 2020
fc63afb
Adding comments on behaviour
diemol Jul 20, 2020
e5c31d6
Debugging
diemol Jul 20, 2020
b5aed83
Logging into docker
diemol Jul 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

jobs:
build-and-test:
# Skip job based on the commit message
# Skip job based on the commit message, only works in push to branches for now
if: contains(toJson(github.event.commits), '[skip ci]') == false
name: Build & test Docker images with random user
runs-on: ubuntu-18.04
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ on:

jobs:
deploy:
# Skip job based on the commit message
if: contains(toJson(github.event.commits), '[skip ci]') == false
name: Deploy Docker images
runs-on: ubuntu-18.04
steps:
Expand All @@ -26,8 +24,12 @@ jobs:
env:
DOCKER_USERNAME: ${{secrets.DOCKER_USERNAME}}
DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}
- name: Deploy new images
run: VERSION="${TAG}" make release
# - name: Deploy new images
# run: VERSION="${TAG}" make release
- name: Tag browser images
run: VERSION="${TAG}" make tag_and_push_browser_images
- name: List Docker images
run: docker images
# - name: Deploy tag latest
# run: VERSION="${TRAVIS_TAG}" make tag_latest
# - name: Deploy release latest
Expand Down
Loading