Do not evaluate Jacobian nor compute LU factorization in oopnlsolve #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Feb 24, 2019
devmotion
approved these changes
Feb 24, 2019
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Maybe you could even remove the previous implementation completely and add an explanation (or a link to the discussion on Github) instead?
ChrisRackauckas
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the CI errors in SciML/DelayDiffEq.jl#103
@devmotion consider that we don't even have unit aware stiff solvers. Trying to handle custom number types with
ludefined on it seems to be unnecessary.