Define prepare_alg dispatch for OrdinaryDiffEq AD algorithms #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
force-pushed
the
prepare_alg
branch
2 times, most recently
from
94ff654 to
8a0a2b5
Compare
ChrisRackauckas
force-pushed
the
prepare_alg
branch
from
8a4d1c3 to
2830d6f
Compare
5 tasks
Contributor
|
This may be the primary cause of the inference regression in Pumas. |
Member
Author
|
This PR causes the biggest decrease to compile times 😅 |
Contributor
|
Well, commenting out the function barrier |
Member
Author
|
But having this allows for the things to fully precompile, which is the full 22 to 3 seconds precompile 🌊 |
Contributor
|
Yeah, I think a better fix is to just avoid the type instability in Pumas (by passing the chunk size in there), which requires #1521. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/DiffEqBase.jl#698