Rewrite the progressbar part of OptimizationOptimisers
#1060
+60
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prbzrg
force-pushed
the
rw-progressbar
branch
from
9cbffa3 to
89e2d0c
Compare
Comment on lines
+137
to
+138
| @info ProgressLogging.Progress(progress_id, iterations / maxiters; | ||
| name = "loss: $(round(first(first(x)); digits=3))") |
There was a problem hiding this comment.
I don't think @info is needed here, as you can use a log level that does not print, but it's picked up by ProgressLogging integrations, such as the VS Code native progress bar. I think that LogLevel(-1) could be enough.
There was a problem hiding this comment.
There was a problem hiding this comment.
And then final needs to manual there as well. At least for now I hotfixed a removal of the ProgressLogging setup
| module OptimizationOptimisers | ||
|
|
||
| using Reexport, Printf, ProgressLogging | ||
| using Reexport, ProgressLogging, UUIDs |
There was a problem hiding this comment.
We shouldn't depend on ProgressLogging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Fixes #1059