remove aliasing from caches #683
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
force-pushed
the
os/remove-aliasing
branch
from
6dc9625 to
1e3fb7c
Compare
ChrisRackauckas
approved these changes
Aug 28, 2025
|
The test failures in wrappers looks real |
|
agreed. |
|
Just FYI I will review this. I am trying to get the CI green (in #695) without this patch just so that if know if this actually breaks anything |
|
The test failures here are real. After the latest patch we only expect the mac pre tests to intermittently fail |
|
I think I might have just fixed the extension issues. Lets see if CI agrees. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to drastically reduce the amount of aliasing between different caches to reduce the possibility of getting them out of sync (e.g. in
reinit!). Things aren't totally deduplicated yet, but the goal is to only haveu,J,fu, andduin a single place each.