Skip to content

Conversation

@sofyalaski
Copy link
Member

@sofyalaski sofyalaski commented Sep 8, 2025

Description

Fixes #1990

Motivation

Probably no other facilities enabled the config for this and it got removed somewhere in the commits

Fixes:

Please provide a list of the fixes implemented in this PR

  • when "archivable/retrievable" is toggled an effect is triggered that does a fullquery request.

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Include archive view mode toggling in the dataset effects to trigger a full dataset query when archivable/retrievable view is toggled.

Bug Fixes:

  • Ensure toggling the archivable/retrievable view mode triggers a fullquery request

Enhancements:

  • Add setArchiveViewModeAction to the list of actions that trigger the fullqueryParams effect

@sofyalaski sofyalaski requested a review from sbliven September 8, 2025 15:53
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sofyalaski sofyalaski changed the title fix the view fix (datasets): makes fullquery request on the view mode change Sep 8, 2025
@sofyalaski sofyalaski changed the title fix (datasets): makes fullquery request on the view mode change fix(datasets): make fullquery request on view mode change Sep 8, 2025
@sofyalaski sofyalaski merged commit 5a9a498 into master Sep 9, 2025
8 of 11 checks passed
@sofyalaski sofyalaski deleted the 1990-fix-archViev-buttons branch September 9, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

archive workflow buttons broken

3 participants