Skip to content

Conversation

@neggles
Copy link
Contributor

@neggles neggles commented Mar 30, 2025

Update uv's configuration schema/sub-schema to allow setting the bare string "all" for default-groups; this is permitted as of v0.6.8 (see changelog here and pull request here)

I went with changing this to an anyOf and adding the specific all string match as one of the valid options since that seems more in line with the rest of the schema's style, but just changing line 90 to "type": ["array", "string", "null"], would work as well. I don't think it's likely that this field will get any other string options in the future, though, so probably constraining to the specific value is the way to go?

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall
Copy link
Member

hyperupcall commented Mar 30, 2025

I don't think it's likely that this field will get any other string options in the future, though, so probably constraining to the specific value is the way to go?

Agreed!.

Sidenote, I'm pretty sure this schema is autogenerated so I'm not sure if this will be overwritten at a later update.

@hyperupcall hyperupcall merged commit 4bda5d4 into SchemaStore:master Mar 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants