Skip to content

Conversation

@benjaminxscott
Copy link
Contributor

📝 totally optional merge - meant as a PoC for how I would do tests from scratch

This branch:

  • trims the large number of test files to a small set of representative files
  • squashes schemas and schemas-tests into a single repo
  • removes notion of negative tests
  • removes manifest file, using file globbing instead under named folders
  • deprecates this repo

Clean build here on a modified travis.cfg

@johnwunder cc:@gtback

@johnwunder
Copy link
Member

Which files did you trim? Was it any of the individual regression tests? IMO all of the regression tests should probably stay (along w/ our samples and whatnot) but I'm totally fine trimming back testing against all those VERIS files.

Agree w/ squashing schemas and schemas-tests

Undecided on negative tests, I can see why they might be necessary to ensure that fields were actually removed but in general are very confusing.

Agree w/ glob.

If we get further consensus I'd be OK merging.

@benjaminxscott
Copy link
Contributor Author

all regression tests are kept, under /issues

veris files were trimmed

@johnwunder
Copy link
Member

perfect. @bworrell thoughts?

@bworrell
Copy link
Contributor

@johnwunder, @bschmoker I think this is probably fine. I'm curious to know which VERIS files were removed and why (though I can guess there was just a lot of redundancy between them all).

@benjaminxscott
Copy link
Contributor Author

@bworrell - all of them besides a few - lmk if it's cool to :shipit:

@bworrell bworrell removed their assignment Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants