Skip to content

Conversation

@madsmtm
Copy link

@madsmtm madsmtm commented Jun 1, 2021

  • Decrease Encoding::BitField size from u32 to u8
    • A bitfield can only be created from integral types, whose maximum size is 64 (which can easily fit inside a u8)
  • Increase Encoding::Array length from u32 to usize
    • @encode can output an array size up to 2^61 - 1 elements:
    NSLog(@"Encoding: %s", @encode(char [((unsigned long long)(2) << 60) - 1]));

These are breaking changes, so we'd have to bump the major version number.

Please correct me on these if I'm wrong!

madsmtm added 2 commits June 1, 2021 14:47
@encode can output an array size up to 2^61 - 1 elements.
A bitfield can only be created from integral types, whose maximum size is 64 (which can easily fit inside a u8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant