-
Notifications
You must be signed in to change notification settings - Fork 24
Sheshuk/fix model notebooks #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ing them to method
In #404, @jpkneller suggested (among other things) moving that class from |
@@ -79,6 +79,7 @@ | |||
# directories to ignore when looking for source files. | |||
exclude_patterns = ['nb/dev'] | |||
|
|||
nbsphinx_allow_errors = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d like to be very strict here, because any errors that slip through will make it to the published documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still strict: I've added the pytest --nbval
step, so we're still having the notebooks checked, but it provides more information: instead of just failing on the first failed notebook during the documentation build, it will run each of them as test and give the output.
Closes #392 , #223
Trying to fix the remaining issues with building the notebooks:
PinchedModel
-derived model classes, because theflux.Container
failed to initialize with a scalar time (shape mismatch)Fornax_*
models - caused by extra parametersinterpolation
,phi
andtheta
. We need to discuss how to handle this in Make signature forSupernovaModel.get_*_spectra
uniform for all models/subclasses #223Fornax_2019
model: Fornax_2019 initial spectra unit is different from other models #403SNOwGLoBES_models
nb - it needs updating, it uses path to already created tar.gz file.AnalyticFluence
- it's incompatible with our ccsn_loaders.Also, currently building the notebooks in the docs is not very informative: if one fails, we don't get any additional information. I'm adding a separate step, calling the pytest on notebooks, so we can see exctly which ones of them are failed, instead of exit on first failure.