chromium: drop the chromium_render_t domain #1043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream no longer supports the SELinux sandbox[1], so no dyntrans is attempted, making this domain redundent. It's been long enough now that it is reasonable to drop this domain. [1] https://github.com/chromium/chromium/blob/0f8100c82dc431809d866e5d0218cbe3c482b20c/sandbox/linux/README.md?plain=1#L31 Signed-off-by: Rahul Sandhu <[email protected]>
Contributor
Author
|
I should note that this shouldn't really cause breakage: the policy doesn't seem to work as is on either X11 or Wayland boxes running the latest version of chrome for me. More patches to come. |
Contributor
|
LGTM. Sure enough I don't see this domain getting used by Chrome 142 at all. Seems unfortunate in my opinion but there's nothing we can do here to preserve the separate domain---the renderer process is just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream no longer supports the SELinux sandbox[1], so no dyntrans is attempted, making this domain redundent. It's been long enough now that it is reasonable to drop this domain.
[1] https://github.com/chromium/chromium/blob/0f8100c82dc431809d866e5d0218cbe3c482b20c/sandbox/linux/README.md?plain=1#L31