feat: esm support on Odata #6061
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…25-esm-support-oData
deekshas8
reviewed
Oct 17, 2025
deekshas8
reviewed
Oct 17, 2025
test-packages/test-services-odata-v2/generate-odata-services.ts
Outdated
Show resolved
Hide resolved
deekshas8
reviewed
Oct 17, 2025
packages/generator/src/generator-without-ts-morph/request-builder/imports.ts
Outdated
Show resolved
Hide resolved
deekshas8
reviewed
Oct 17, 2025
deekshas8
reviewed
Oct 17, 2025
deekshas8
requested changes
Oct 21, 2025
deekshas8
reviewed
Oct 22, 2025
packages/generator/src/generator-without-ts-morph/request-builder/imports.spec.ts
Outdated
Show resolved
Hide resolved
deekshas8
reviewed
Oct 23, 2025
deekshas8
reviewed
Oct 23, 2025
deekshas8
requested changes
Oct 23, 2025
deekshas8
requested changes
Oct 23, 2025
Co-authored-by: Deeksha Sinha <[email protected]>
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
packages/generator/src/generator-without-ts-morph/request-builder/file.ts
Outdated
Show resolved
Hide resolved
deekshas8
reviewed
Oct 27, 2025
packages/generator/src/generator-without-ts-morph/request-builder/imports.ts
Outdated
Show resolved
Hide resolved
deekshas8
reviewed
Oct 27, 2025
deekshas8
reviewed
Oct 27, 2025
deekshas8
requested changes
Oct 27, 2025
Contributor
deekshas8
left a comment
deekshas8
left a comment
There was a problem hiding this comment.
It's almost there, just some code cleanup and restructuring needed, Please consider ALL comments and lets discuss if you have questions.
…oud-sdk-js into I753325-esm-support-oData
…oud-sdk-js into I753325-esm-support-oData
deekshas8
reviewed
Nov 11, 2025
deekshas8
requested changes
Nov 11, 2025
deekshas8
reviewed
Nov 14, 2025
deekshas8
reviewed
Nov 14, 2025
| ]); | ||
| }); | ||
|
|
||
| const esmOptions = { |
Contributor
There was a problem hiding this comment.
Please declare this inside the it
Contributor
There was a problem hiding this comment.
Only common variables should be declared within describe
…oud-sdk-js into I753325-esm-support-oData
deekshas8
requested changes
Nov 14, 2025
Contributor
deekshas8
left a comment
deekshas8
left a comment
There was a problem hiding this comment.
I found two issues during compilation, having to do with incorrect tsconfig and missing type in package.json.
| npmPackageName: service.serviceOptions.packageName, | ||
| sdkVersion: await getSdkVersion(), | ||
| description: packageDescription(service.speakingModuleName), | ||
| oDataVersion: service.oDataVersion |
Contributor
There was a problem hiding this comment.
Suggested change
| oDataVersion: service.oDataVersion, | |
| generateESM: options.generateESM |
This needs to be passed here as well, else the package.json doesn't have type: module for esm
| export const defaultTsConfig = { | ||
| compilerOptions: { | ||
| target: 'es2021', | ||
| module: 'commonjs', |
Contributor
There was a problem hiding this comment.
This is always commonjs which is a problem if you set generateESM to true. Because the generated ESM code gets compiled to commonjs. both module and moduleResolution should also be conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generateESM flag, used in both generator and openapi generator packages controls if the generated client code follows the ECMACScript Module (ESM) syntax or the default, CommonJS one.
when generateESM: true is set, the generator produces code which folllows the ESM syntax.