Skip to content

Remove StringBuilder in Logback TimestampConverter #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Remove StringBuilder in Logback TimestampConverter #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0738cc6
Changed from StringBuilder to String
rahuldeepattri Feb 25, 2021
22fb02a
Fix wrong Indentation
rahuldeepattri Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...ng-support-logback/src/main/java/com/sap/hcp/cf/logback/converter/TimestampConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ public class TimestampConverter extends ClassicConverter {

@Override
public String convert(ILoggingEvent event) {
StringBuilder appendTo = new StringBuilder();
Instant now = Instant.now();
long timestamp = now.getEpochSecond() * 1_000_000_000L + now.getNano();
appendTo.append(timestamp);
return appendTo.toString();
Instant now = Instant.now();
long timestamp = now.getEpochSecond() * 1_000_000_000L + now.getNano();
return String.valueOf(timestamp);
}

@Override
Expand Down