Add Exceptions Type and Message #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix and run the code and documentation generation for the two new fields exception_type and exception_message. Changes to the Python scripts are required for newer pyyaml versions. Signed-off-by: Karsten Schnitter <[email protected]>
Adds the two fields exception_type and exception_message to the BaseFieldSuppliers for Log4j and Logback. This allows users to override the provided values with custom FieldSuppliers. Basic Unit Tests were added. Performance implications should be minimal for events without exceptions. If there are exceptions, the only longer check is for the message to be non-blank. Signed-off-by: Karsten Schnitter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160 outlines the requirement to have exception type and messages in the emitted log events. This capability has been added to the BaseFieldSuppliers for the Log4j and Logback integrations. This allows users to overwrite the default values by custom ContextFieldSuppliers. The stacktrace remains to be added at the very end of the log event generation.