Fix logback stacktrace information #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v3.6.0 the stacktrace feature was not working properly in the logback implementation. Amongst the missing information was the exception class, the exception message and suppressed or caused exceptions. The proposed change brings back the original coding used before v3.6.0, which is also used in the log4j2 implementation. Signed-off-by: Karsten Schnitter <[email protected]>
KarstenSchnitter
requested review from
christiand93,
juergen-walter and
nicklas-dohrn
|
I like the improvement of the test |
Fix is a move forward and not a revert, what I initially assumed based on the comment. Therefore it took longer for me to understand. |
|
It would be great if this were included in the next update of SAP Java Buildpack (1.53.0) on BTP on May 5. The currently announced change is to 3.6.1 only. |
|
I cannot really comment on the progress on the SAP Java Buildpack. I know, that an internal process has started to provide the fix with a buildpack hotfix. |
|
According to What's New information this has been integrated into SAP Java Buildpack 1.53.2 and 1.52.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #145:
Since v3.6.0 the stacktrace feature was not working properly in the logback implementation.
Amongst the missing information was the exception class, the exception message and
suppressed or caused exceptions. The proposed change brings back the original coding
used before v3.6.0, which is also used in the log4j2 implementation.
Signed-off-by: Karsten Schnitter [email protected]