Add support for W3C traceparent HTTP header #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The contents of the HTTP header "traceparent" is extracted and logged with every log event in field "w3c_traceparent". This is done for regular application log messages and request logs. The feature allows correlation of log messages with requests and possible traces. Signed-off-by: Karsten Schnitter <[email protected]>
When no X-CorrelationId header is found, the CorrelationIdFilter now searches for a traceparent header. It will take the trace-id as correlation-id, if the header value follows the W3C definition. This filter can be configured with customisable http header configurations but keeps the old interface for compatibility. Signed-off-by: Karsten Schnitter <[email protected]>
nicklas-dohrn
approved these changes
Feb 15, 2022
| String correlationId = HttpHeaderUtilities.getHeaderValue(request, correlationHeader); | ||
| if (correlationId == null || correlationId.isEmpty() || correlationId.equals(Defaults.UNKNOWN)) { | ||
| if (isBlankOrDefault(correlationId)) { | ||
| correlationId = getCorrelationIdFromTraceparent(request); |
There was a problem hiding this comment.
I guess this works, because correlationId is nullable, so the parsing can fail, and still work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contents of the HTTP header "traceparent" is extracted and logged
with every log event in field "w3c_traceparent". This is done for regular
application log messages and request logs. The feature allows correlation
of log messages with requests and possible traces.
Signed-off-by: Karsten Schnitter [email protected]