Remove side-effect in RequestRecordFactory #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the http header propagation to log fields in the RequestRecordFactory. This feature was refactored to the AddHttpHeadersToLogContextFilter. The change include several test to ensure correct behaviour.
jomora
reviewed
Jul 21, 2021
Comment on lines
51
to
53
| Map<String, Object> finedLineAsMapWith(String key, String expected) throws IOException { | ||
| return fineLineAsMapWith(key, expected); | ||
| } |
There was a problem hiding this comment.
What does fined mean in the method name? Is this a typo, i.e. do you mean find or fine, or am I missing something?
There was a problem hiding this comment.
It's a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #111
This change removes the http header propagation to log fields in the RequestRecordFactory.
This feature was refactored to the AddHttpHeadersToLogContextFilter. The change include
several test to ensure correct behaviour.