Skip to content

der: simplify der_cmp for Length #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −11
Open

der: simplify der_cmp for Length #1997

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions der/src/length.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ impl Length {
#[cfg(feature = "ber")]
pub(crate) const EOC_LEN: Self = Self::new(2);

/// Maximum number of octets in a DER encoding of a [`Length`] using the
/// rules implemented by this crate.
pub(crate) const MAX_SIZE: usize = 5;

/// Create a new [`Length`] for any value which fits inside of a [`u16`].
///
/// This function is const-safe and therefore useful for [`Length`] constants.
Expand Down Expand Up @@ -336,13 +332,8 @@ impl Encode for Length {

impl DerOrd for Length {
fn der_cmp(&self, other: &Self) -> Result<Ordering> {
let mut buf1 = [0u8; Self::MAX_SIZE];
let mut buf2 = [0u8; Self::MAX_SIZE];

let buf1 = self.encode_to_slice(&mut buf1)?;
let buf2 = other.encode_to_slice(&mut buf2)?;

Ok(buf1.cmp(buf2))
// The DER encoding has the same ordering as the integer value
Ok(self.inner.cmp(&other.inner))
}
}

Expand Down