Fix libm intrinsics for versions newer than 0.2.11
#364
+8
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuguzT
changed the title
libm intrinsics for versions newer that 0.2.11libm intrinsics for versions newer than 0.2.11
tuguzT
requested review from
eddyb,
LegNeato,
Firestar99 and
schell
as code owners
LegNeato
approved these changes
Aug 16, 2025
nazar-pc
reviewed
Aug 16, 2025
| @@ -59,8 +59,7 @@ tracing = "0.1" | |||
| tracing-subscriber = { version = "0.3.3", features = ["env-filter", "json"] } | |||
| num-traits = { version = "0.2.15", default-features = false } | |||
| glam = { version = ">=0.22, <=0.30", default-features = false } | |||
| # libm 0.2.12 is a breaking change with new intrinsics | |||
| libm = { version = ">=0.2.5, <=0.2.11", default-features = false } | |||
| libm = { version = ">=0.2.5", default-features = false } | |||
There was a problem hiding this comment.
I believe this version is equivalent to just 0.2.5, which is a more common format in Rust crates. It was only written like that before due to a range constraint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #242 in another way by allowing to update
libmdependencyI think that backend tried to replace all the public functions usages inside of
libmitself, which caused issue #242 in the first place.Without suggested changes, compilation fails with ICE similar to this one:
Note that local
DefIdhaskratefield defined asLOCAL_CRATE, orCrateNum::ZERO, whichDisplayimpl is exactlycrate0