Fixed 'is_i128', making it check if the type is an intiger, before casting it to check the intiger bit width #270
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting it to check the intiger bit width
LegNeato
requested changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks! Can't believe I missed that. We should probably fix
rust-cuda/crates/rustc_codegen_nvvm/src/ty.rs
Line 239 in 5fb10d3
float_width seems to behave correctly.
LegNeato
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small correctness fix: using 'is_i128' on non-int types is not correct, and will trigger LLVM assertions in debug mode.
This PR makes us check if the type is an int first.