fix: early return for module file error in AST parsing #4151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xllx0
commented
Sep 12, 2025
| @@ -0,0 +1,8 @@ | |||
| struct S { | |||
There was a problem hiding this comment.
Not sure on the exact decorators needed here, or if this test should go into the xfail directory. The test is expected to fail compilation, just with an error message instead of an ICE.
There was a problem hiding this comment.
grep for dg-error in the testsuite directory -- that should give you some nice examples for expecting error messages
0xllx0
force-pushed
the
fix/issue-4145
branch
from
23c234f to
7e5d59c
Compare
powerboat9
reviewed
Sep 14, 2025
0xllx0
force-pushed
the
fix/issue-4145
branch
from
7e5d59c to
4abdf2e
Compare
CohenArthur
approved these changes
Sep 15, 2025
0xllx0
force-pushed
the
fix/issue-4145
branch
2 times, most recently
from
0e7b692 to
98c8cc2
Compare
Converts an assert into an early return during AST parsing. Resolves: Rust-GCC#4145 gcc/rust/ChangeLog: * ast/rust-ast.cc (Module::process_file_path): empty module early return Signed-off-by: Elle Rhumsaa <[email protected]>
gcc/testsuite/ChangeLog: * rust/compile/issue-4145.rs: New test. Signed-off-by: Elle Rhumsaa <[email protected]>
0xllx0
force-pushed
the
fix/issue-4145
branch
from
98c8cc2 to
b84e8ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for making Rust GCC better!
If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.
Here is a checklist to help you with your PR.
make check-rustpasses locallyclang-formatgcc/testsuite/rust/Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.
Converts an assert into an early return during AST parsing.
Resolves: #4145