-
Notifications
You must be signed in to change notification settings - Fork 187
name-resolution: Add std/core prelude resolution #4149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CohenArthur
wants to merge
3
commits into
Rust-GCC:master
Choose a base branch
from
CohenArthur:std-prelude-resolution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -560,23 +560,63 @@ class NameResolutionContext | |
if (resolved_nodes.find (Usage (seg_id)) == resolved_nodes.end ()) | ||
map_usage (Usage (seg_id), Definition (id)); | ||
}; | ||
|
||
tl::optional<Rib::Definition> resolved = tl::nullopt; | ||
|
||
switch (ns) | ||
{ | ||
case Namespace::Values: | ||
return values.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
resolved | ||
= values.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
break; | ||
case Namespace::Types: | ||
return types.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
resolved | ||
= types.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
break; | ||
case Namespace::Macros: | ||
return macros.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
resolved | ||
= macros.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
break; | ||
case Namespace::Labels: | ||
return labels.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
resolved | ||
= labels.resolve_path (segments, mode, insert_segment_resolution, | ||
collect_errors); | ||
break; | ||
default: | ||
rust_unreachable (); | ||
} | ||
|
||
// If it fails, switch to std prelude resolution if it exists | ||
if (prelude && !resolved) | ||
{ | ||
// TODO: Factor this with the above | ||
switch (ns) | ||
{ | ||
case Namespace::Values: | ||
return values.resolve_path (segments, mode, | ||
insert_segment_resolution, | ||
collect_errors, *prelude); | ||
case Namespace::Types: | ||
return types.resolve_path (segments, mode, | ||
insert_segment_resolution, | ||
collect_errors, *prelude); | ||
case Namespace::Macros: | ||
return macros.resolve_path (segments, mode, | ||
insert_segment_resolution, | ||
collect_errors, *prelude); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should probably use a temporary vector instead of |
||
case Namespace::Labels: | ||
return labels.resolve_path (segments, mode, | ||
insert_segment_resolution, | ||
collect_errors, *prelude); | ||
default: | ||
rust_unreachable (); | ||
} | ||
} | ||
|
||
return resolved; | ||
} | ||
|
||
template <typename S, typename... Args> | ||
|
@@ -676,6 +716,9 @@ class NameResolutionContext | |
std::forward<Args> (args)...); | ||
} | ||
|
||
/* If declared with #[prelude_import], the current standard library module */ | ||
tl::optional<NodeId> prelude; | ||
|
||
private: | ||
/* Map of "usage" nodes which have been resolved to a "definition" node */ | ||
std::map<Usage, Definition> resolved_nodes; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably just add a new variant to
ResolutionMode
, instead of adding a user-providedstarting_point
in addition tomode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ForeverStack
could probably fetch the node id associated with the language prelude fromNameResolutionContext
-- might be kind of tricky to get that working, though. You could also just have eachForeverStack
keep astd::reference_wrapper
to the currently set preludeNode
.