chore: refactoring rust_error_at "redefined multiple times"

[sriganeshres]

gcc/rust/ChangeLog:

* resolve/rust-ast-resolve-base.h (redefined_error): created a function for rust_error_at for redefined at multiple times.
* resolve/rust-ast-resolve-implitem.h: changed rust_error_at to redefined_error.
* resolve/rust-ast-resolve-stmt.cc (ResolveStmt::visit): changed rust_error_at to redefined_error.
* resolve/rust-ast-resolve-stmt.h: changed rust_error_at to redefined_error.
* resolve/rust-ast-resolve-toplevel.h: changed rust_error_at to redefined_error.

• GCC development requires copyright assignment or the Developer's Certificate of Origin sign-off, see https://gcc.gnu.org/contribute.html or https://gcc.gnu.org/dco.html
• Read contributing guidlines
• make check-rust passes locally
• Run clang-format
• Fixes Refactor redefined multiple times Error #2436

[sriganeshres]

@CohenArthur Take a look at this pull request

[CohenArthur]

the code looks good! could you check that this doesn't conflict with the changes @powerboat9 made in #3519? just rebasing your code on the most recent master once #3519 is merged will be enough. thanks!

[sriganeshres]

I have solved the merge conflicts.

[powerboat9]

You should modify the PR so it doesn't contain merge commits. It looks like an easy way to do that in your case would be to run git reset --soft b79c452 and then git gcc-commit-mklog again -- although you should be prepared to copy-paste your existing commit message as your new commit message, if you don't want to have to retype it.

[sriganeshres]

I have solved the merge conflict

[philberty]

I dont think "chore" is a good term in the git commit message. Just do:

gccrs: refactor error diagnostic so it can be reused.

[sriganeshres]

@philberty i have changed the name

[philberty]

LGTM