[E0617] Attempt for invalid type variable in variadic function
#2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some certain rust types must be cast before passing them to a variadic function, because of arcane ABI rules dictated by the C standard. To fix the error, cast the value to the type specified by the error message. gcc/rust/ChangeLog: * typecheck/rust-tyty-call.cc (TypeCheckCallExpr::visit): Added ErrorCode & more fixit hints. gcc/testsuite/ChangeLog: * rust/compile/variadic.rs: Added new checks. Signed-off-by: Muhammad Mahad <[email protected]>
MahadMuhammad
commented
Sep 17, 2023
Comment on lines
-187
to
+190
| rust_error_at (arg_locus, | ||
| rich_location richloc (line_table, arg_locus); | ||
| richloc.add_fixit_replace ( | ||
| "cast the value to c_int: as c_int"); | ||
| rust_error_at (richloc, ErrorCode::E0617, |
There was a problem hiding this comment.
Combining all of these into one function with different messages might seem like a bit overkill, but if it works better, I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to pass
invalid typevariable into avariadicfunction -E0617There are some certain rust types must be cast before passing them to a variadic function, because of arcane ABI rules dictated by the C standard. To fix the error, cast the value to the type specified by the error message.
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: