diagnostics: Added non-const rich_location * function
#2574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, gccrs using the const `rich_location &`, and then using the cast to convert it to the functions which was used to emit the errors, having the overloaded is good, similiar to other frontends. gcc/rust/ChangeLog: * rust-diagnostics.cc (rust_be_error_at): Added overload function. (rust_error_at): non-const `rich_location *` function. * rust-diagnostics.h (rust_error_at): Implementation of overloaded function. (rust_be_error_at): likewise. * rust_error_codes.def: Added GNU license. Signed-off-by: Muhammad Mahad <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
P-E-P
approved these changes
Aug 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gccrs using the const
rich_location &, and then using the cast to convert it to the functions which was used to emit the errors, having the overloaded is good, similiar to other frontends.gcc/rust/ChangeLog: