Apply #1556 on master #1585
Merged
Apply #1556 on master #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
force-pushed
the
apply-1556-master
branch
2 times, most recently
from
618706d to
d1c4084
Compare
CohenArthur
force-pushed
the
apply-1556-master
branch
from
d1c4084 to
94d1116
Compare
|
@abbasfaisal I commented out a bunch of code from the constant evaluator in order to avoid some warnings. If you want I can open up some issues to put it back in at some point |
This also comments out a now unused function
|
bors r+ |
|
Build succeeded: |
tschwinge
added a commit
that referenced
this pull request
Dec 14, 2022
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
tschwinge
added a commit
that referenced
this pull request
Dec 4, 2024
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Mar 10, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Apr 28, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Apr 29, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Apr 29, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Jul 22, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Jul 23, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Jul 23, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
that referenced
this pull request
Jul 30, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Aug 5, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Aug 27, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Aug 27, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Aug 27, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Aug 27, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
that referenced
this pull request
Aug 27, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
that referenced
this pull request
Sep 8, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the #1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts #1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 14, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 16, 2025
As discussed in <https://inbox.sourceware.org/gcc-patches/[email protected]>: > '-Werror=overloaded-virtual' is implied as by default, we have > '-Woverloaded-virtual' and '-Werror' [for '--enable-bootstrap' builds]. > ([...]) > (Maybe that isn't active for '--disable-bootstrap' builds, but that's > "OK".) For '--disable-bootstrap' builds, we still have '-Woverloaded-virtual', and any new such diagnostics will be caught by the Rust-GCC#1026 "check for new warnings" machinery, so effectively that does implement '-Werror', too. > '-Wno-unused-parameter' [did] move into > 'rust-warn' This reverts Rust-GCC#1585 commit a32ef7a.
dkm
pushed a commit
to dkm/gccrs
that referenced
this pull request
Sep 16, 2025
This reverts Rust-GCC#1585 commit 94d1116. Conflicts: .github/bors_log_expected_warnings ... manually resolved and adjusted; let's see...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably wonder about our usage of
-Wno-unused-parameter:)