feat: add react-markdown and remark-gfm dependencies; refactor Description component to use MD for rendering #1613
+1,564
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found. |
TravellerOnTheRun
requested changes
Nov 14, 2025
Contributor
TravellerOnTheRun
left a comment
TravellerOnTheRun
left a comment
There was a problem hiding this comment.
Almost good to go
Contributor
2 things we discussed on the daily:
|
…ption component to use MD for rendering
Freshenext
force-pushed
the
markdown-rendering
branch
from
38e32fd to
b3ed6cc
Compare
Collaborator
Done |
TravellerOnTheRun
approved these changes
Nov 20, 2025
Contributor
TravellerOnTheRun
left a comment
TravellerOnTheRun
left a comment
There was a problem hiding this comment.
As the markdown is a new feature and we did not anticipate these issues, I give it a pass, but I added some things to consider.
|
|
||
| return ( | ||
| <> | ||
| {!isExpanded && ( |
Contributor
There was a problem hiding this comment.
Is this a temporary solution? Cause it will lose the animation going from preview text to full
Contributor
There was a problem hiding this comment.
Maybe write a TODO here as well
Collaborator
There was a problem hiding this comment.
I tested it - animation is still there 😁
Ken-li-iov
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DAO-1967
Screenshots
What
MDcomponent that wrapsreact-markdownwith project-specific styling and configuration. The component uses existing Typography components (Header, Paragraph, Link) to maintain design system consistency.Descriptioncomponent to eliminate redundantisDesktopchecks and simplified the rendering logic with early returns.Why
Previously, proposal descriptions were rendered as plain text, limiting formatting options and making longer technical proposals harder to read.
Also Tally supports MD, so we can render proposals created in Tally
With Markdown support, proposal creators can now use:
This improves readability and allows for more professional, well-structured proposals without compromising security (images are blocked by default).