Metadata-driven subtasks: delegation flow, auto-resume, nested returns, UI badges, tests, docs #9090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Draft / In Progress
and removed
Issue/PR - Triage
hannesrudolph
force-pushed
the
feat/metadata-delegation-subtasks-qa
branch
from
f71b6bb to
53f3b2d
Compare
hannesrudolph
added a commit
that referenced
this pull request
Nov 7, 2025
hannesrudolph
force-pushed
the
feat/metadata-delegation-subtasks-qa
branch
from
6d0d066 to
9fa17c7
Compare
…nused import; type-safe ExtensionChannel event publishing
The Task.resumeAfterDelegation() method was added in the implementation but the test mocks were not updated accordingly. This caused test failures with 'resumeAfterDelegation is not a function' errors. Updated mock task instances in: - src/__tests__/history-resume-delegation.spec.ts - src/__tests__/attempt-completion-delegation.spec.ts All mocks now include: - resumeAfterDelegation: vi.fn().mockResolvedValue(undefined) - overwriteClineMessages: vi.fn().mockResolvedValue(undefined) (where needed) - overwriteApiConversationHistory: vi.fn().mockResolvedValue(undefined) (where needed)
hannesrudolph
force-pushed
the
feat/metadata-delegation-subtasks-qa
branch
from
b2a0e60 to
d734788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3,558 of these added lines are tests :o
Per-test-file additions (top 20)
722 · src/tests/attempt-completion-delegation.spec.ts
381 · src/tests/history-resume-delegation.spec.ts
365 · src/tests/attempt-completion-todos-gate.spec.ts
328 · src/tests/checkpoint-delegation-abort-noise.spec.ts
308 · src/tests/ipc-start-new-task-during-delegation.spec.ts
238 · src/tests/nested-delegation-resume.spec.ts
195 · webview-ui/src/components/history/tests/DelegationUI.spec.tsx
187 · src/tests/api-delegation-forwarding.spec.ts
169 · src/tests/single-open-invariant.spec.ts
158 · src/tests/aborted-loop-unhandled-rejection.spec.ts
139 · src/tests/delegation-open-terminate-ui.spec.ts
117 · packages/cloud/src/bridge/tests/ExtensionChannel.test.ts
75 · src/core/tools/tests/newTaskTool.spec.ts
72 · src/tests/provider-delegation.spec.ts
48 · src/tests/delegation-events.spec.ts
44 · src/tests/new-task-delegation.spec.ts
10 · src/core/webview/tests/ClineProvider.spec.ts
2 · webview-ui/src/context/tests/ExtensionStateContext.spec.tsx
Delegation-first flow, single-open invariant
Auto-resume parent after reopen via Task.resumeAfterDelegation() and startTask:false in ClineProvider.reopenParentFromDelegation()
Suppress checkpoint/aborted-loop noise via guarded catch in Task.startTask() and checkpoint guard in index.ts
Nested returns via metadata parent resolution in attemptCompletionTool.ts
Delegation badge/link persistence and metadata-safe history update in ClineProvider.ts and UI: TaskItem.tsx
Docs updated: task-orchestration-new-task-tool.md
Tests added/updated: attempt-completion-delegation.spec.ts, nested-delegation-resume.spec.ts, aborted-loop-unhandled-rejection.spec.ts, delegation-open-terminate-ui.spec.ts, DelegationUI.spec.tsx
How to test