Fix CMake installed files by removing physac.hpp from the list #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file physac.hpp got removed in d19cbcc, but remained in `install/CMakeLists.txt`, causing `cmake --install` to fail.
|
Good find 👍 .... As for GLOB-ing it, that's generally frowned upon in the CMake-world, but I'd be down for that change 👍 |
RobLoach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file physac.hpp got removed in
d19cbcc, but remained in
install/CMakeLists.txt, causingcmake --installto fail.Just removing it from the list minimizes changes, but seeing as every
.hppfile gets added to the install list maybe something like this would be a better fit?