-
Notifications
You must be signed in to change notification settings - Fork 95
Adds Google login Maestro flow #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JayShortway
wants to merge
6
commits into
main
Choose a base branch
from
maestro-google-login
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a646c6c
Adds google-login.yml.
JayShortway 96ee89e
Moves google-login.yml to subdirectory so it isn't tested.
JayShortway 9eab50f
Adds dedicated Google login flows for API 32 and API 36.
JayShortway ad50997
Adds a google-login.yml flow that selects the flow to use based on th…
JayShortway a346fe4
Merge branch 'main' into maestro-google-login
JayShortway 3816f1e
Merge branch 'main' into maestro-google-login
JayShortway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # We could save a few steps in this flow by immediately opening the Add Account screen in the Settings app: | ||
| # adb shell am start -a android.settings.ADD_ACCOUNT_SETTINGS -n com.android.settings/.accounts.AddAccountSettings; | ||
|
|
||
| # This flow requires passing the user name and password as parameters like so: | ||
| # maestro test -e [email protected] -e PASSWORD=123 google-login.yml | ||
|
|
||
| appId: "com.android.settings" | ||
| --- | ||
| - launchApp | ||
| - scrollUntilVisible: | ||
| element: "Passwords, passkeys & accounts" | ||
| - tapOn: "Passwords, passkeys & accounts" | ||
| - runFlow: | ||
| when: | ||
| notVisible: "None selected" | ||
| commands: | ||
| - tapOn: "Change" | ||
| - tapOn: "None" | ||
| - tapOn: "Turn off" | ||
| - back | ||
| - tapOn: "Add account" | ||
| - tapOn: "Google" | ||
| - tapOn: | ||
| id: identifierId | ||
| - inputText: ${USERNAME} | ||
| - tapOn: NEXT | ||
| - assertVisible: "Show password" | ||
| - inputText: ${PASSWORD} | ||
| - tapOn: NEXT | ||
| - tapOn: "I agree" | ||
| - waitForAnimationToEnd | ||
| # Skip and cancel whatever Google asks us | ||
| - repeat: | ||
| while: | ||
| visible: "Cancel" | ||
| commands: | ||
| - tapOn: "Cancel" | ||
| - repeat: | ||
| while: | ||
| visible: "Skip" | ||
| commands: | ||
| - tapOn: "Skip" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string seems to only be available in newer android versions (in API 33, it says Passwords and accounts), but as you said in the comments, we might be able to bypass those steps with the adb command above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good point! I thought about being smart with regex, but it seemed simpler and less confusing to make 2 separate flows:
maestro/google-login/api/36.ymlfor API >= 36maestro/google-login/api/32.ymlfor API >= 32I'm not entirely sure if these are the exact API boundaries, but we can tweak as needed.
There's also a
maestro/google-login/google-login.ymlfile, which selects the right API flow to use based on theAPI_VERSIONparameter that is passed. I'm not sure of a way to automatically get the Android version in Maestro, but we can improve it if we find one. So to be clear, this is how it would work now: