Polling fix #149
Polling fix #149
Conversation
railib/__init__.py
Outdated
| # limitations under the License. | ||
|
|
||
| __version_info__ = (0, 7, 0) | ||
| __version_info__ = (0, 7, 2) |
| f, | ||
| overhead_rate: float, | ||
| start_time: int = time.time(), | ||
| start_time: float = None, |
There was a problem hiding this comment.
I dunno if the type checker is configured differently in the SDK but in pyrel's repo + my editor it's a type error not to explicitly union with None when assigning a default of None.
There was a problem hiding this comment.
Oh yes, this is a type error. But it's all over the codebase and I figure it makes sense to be consistent and address that concern in a separate PR.
joshuafcole
left a comment
joshuafcole
left a comment
There was a problem hiding this comment.
added minor style notes but I think its good to ship when you're satisfied (heading to vote so will be spotty)
| # limitations under the License. | ||
|
|
||
| __version_info__ = (0, 7, 0) | ||
| __version_info__ = (0, 7, 3) |
There was a problem hiding this comment.
@joshuafcole Regarding the version bump: I actually neglected to bump; it shows as a double-bump because of a Git error on my part that apparently got handled by GitHub in kind of a weird way. (Namely, I forgot to go back to main before creating my new branch and instead used my previous branch.)
Anyway, it should be OK now, GitHub's interface weirdness notwithstanding.
There was a problem hiding this comment.
Hey, the diff shows correctly now that I merged main 🤷
There was a problem hiding this comment.
Sounds good, did you want to cut a release or should I?
There was a problem hiding this comment.
Shoot; good catch. I thought I did this but apparently not.
Done now.
2 participants
There was a mistake in a polling function having to do with the way Python evaluates default values for arguments (at definition time).
This PR moves the
time.time()call to the body of the function.