Skip to content

Conversation

@NRHelmi
Copy link
Contributor

@NRHelmi NRHelmi commented May 5, 2023

Bum up requests-toolbelt version to 1.0.0
Fix urllib3 and requests dependencies versions
Run tests using multiple python versions [3.7, 3.8, 3.9]

@NRHelmi NRHelmi marked this pull request as ready for review May 5, 2023 11:17
@NRHelmi NRHelmi requested review from cpetitpas, larf311 and torkins May 5, 2023 11:17
@larf311
Copy link

larf311 commented May 5, 2023

Generally I like running tests with multiple versions, however, these are more end to end tests than unit tests so I think this is overkill.

@torkins torkins merged commit 837e5c6 into main May 5, 2023
@torkins
Copy link
Collaborator

torkins commented May 5, 2023

just a comment - this is blocking a hi-pri incident and Helmi is not in to address comments on the matrix usage so we will discuss and address later, merging now

@NRHelmi
Copy link
Contributor Author

NRHelmi commented May 6, 2023

Generally I like running tests with multiple versions, however, these are more end to end tests than unit tests so I think this is overkill.

The matrix usage will only affect the python sdk repo, raicode and other repositories will use the default version from action.yaml file which is python 3.7. We do the same for julia and java sdks

@NRHelmi NRHelmi deleted the hnr-ncdnts-653 branch May 6, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants